Change the return type of count_code_block_tokens #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalance
force-pushed
the
fix_count_code_block_tokens
branch
from
0f1fdea
to
ef1c276
Compare
Byron
force-pushed
the
fix_count_code_block_tokens
branch
from
794d3a4
to
4c0b4b2
Compare
…AULT_CODE_BLOCK_TOKEN_COUNT`. That way it's possible to correctly determine the amount of fenced code-block tokens needed to render all given events such that code-blocks are retained.
Byron
force-pushed
the
fix_count_code_block_tokens
branch
from
4c0b4b2
to
e339365
Compare
|
Thanks a lot! This time I invested more time into the review and hopefully made reasonable improvements. The new release is here: https://github.com/Byron/pulldown-cmark-to-cmark/releases/tag/v11.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the return type of
count_code_block_tokens.By this change, the function can show "user can specify an arbitrary
code_block_token_count" throughNonereturn value.Refer: #20