Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog tag #574

Closed
biumiamy opened this issue Sep 19, 2023 · 9 comments
Closed

dialog tag #574

biumiamy opened this issue Sep 19, 2023 · 9 comments
Assignees

Comments

@biumiamy
Copy link
Collaborator

biumiamy commented Sep 19, 2023

For this article:
Chronoreferencing the Italian-Slovenian Borderlands. Citizen Science, Digital Hermeneutics and Output Criticism
http://10.240.4.179/en/article/6ig87tC5GKjQ

  • currently the table formatting looks like this on the N- and H-layer (the colors are not aligned with H-layer color scheme)

Image

Image

desirable:

  • change color scheme to match H-layer
  • align styling on N- and H-layer to look the same even in the preview

Image

or dialog style like a chat for comfortable reading:

Image

Is there sth like this we can do in the frontend?

And bonus question: could the text appear interactively to the audio file?

@biumiamy biumiamy changed the title table formatting issue table formatting/colour issue Sep 19, 2023
@biumiamy
Copy link
Collaborator Author

biumiamy commented Sep 20, 2023

  • add dialog tag (dialog-name-*)
  • add sound tag (sound-name-*)
  • match the table to the style of the last image above (chat style)

@biumiamy
Copy link
Collaborator Author

biumiamy commented Sep 20, 2023

another issue: sometimes there are line breaks, but they are shown as a new line in the table.. need to find a solution for that (?).. sometimes it works, sometimes not it seems

@danieleguido
Copy link
Collaborator

You have to put explicit <br /> and I suggest to add pipe character at the beginning of every new line

A B
Hello B!
Hello A! ...
How are you?
Not bad!
What about you?

@eliselavy
Copy link
Collaborator

@biumiamy
Copy link
Collaborator Author

and issue with audio file in the example notebook - need to fix: https://github.com/C2DH/jdh-notebook/blob/master/examples/sound-dialog.ipynb

@biumiamy
Copy link
Collaborator Author

biumiamy commented Oct 6, 2023

Issue with sound resolved

@biumiamy
Copy link
Collaborator Author

Requested: Right align second speaker:

Image

@biumiamy
Copy link
Collaborator Author

I checked all tables here

@biumiamy biumiamy changed the title table formatting/colour issue new dialog tag Oct 19, 2023
@biumiamy biumiamy changed the title new dialog tag dialog tag Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants