Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't re-read in CRTF files that have regions with spaces in their names #1188

Closed
jehibbard opened this issue Aug 26, 2022 · 0 comments · Fixed by #1212
Closed

Can't re-read in CRTF files that have regions with spaces in their names #1188

jehibbard opened this issue Aug 26, 2022 · 0 comments · Fixed by #1212
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jehibbard
Copy link

jehibbard commented Aug 26, 2022

Describe the bug
CARTA v3.0 won't read in CRTF file when region names have spaces in them

To Reproduce
Steps to reproduce the behavior:

  1. Open an image
  2. Create a region
  3. In the region manager, give it a name with spaces in it (e.g. Disk Red Edge, Disk Blue Edge)
  4. Export the region as a CRTF file
  5. Delete the regions
  6. Read the CRTF file that you previously saved
  7. CARTA will pop-up a red error box about string syntax error
  8. Change the names to have no spaces and resave and you'll be able to load it properly

Expected behavior
I expect it to read in and display the saved regions

Screenshots or videos
Attached is a screenshot of reading in the region in v3.0-beta3 (on the left) and trying to read it in on my new installation of v3.0
Screen Shot 2022-08-26 at 1 07 19 PM

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS 12.5.1, MBP M1 Pro
  • Browser [e.g. chrome, safari, electron app]: Safari & Chrome
  • Browser version [e.g. 22]: Safari 15.6.1, Chrome v104.0.5112.101
  • Backend branch [e.g. dev, v3b2 release]: v3.0 release (installed via brew install cartavis/tap/carta)
  • Frontend branch [e.g. dev, v3b2 release]: v3.0 release (installed via brew install cartavis/tap/carta

Additional context
Add any other context about the problem here.
I did not have this problem in v3.0-beta3 (and can actually import the crtf file created in v3.0 and see them in v3-beta)
I quit CARTA and started up a new session and went through the steps above and still got the same result.
I used a different image, repeated the steps, and got the same result

@kswang1029 kswang1029 transferred this issue from CARTAvis/carta-frontend Aug 26, 2022
@kswang1029 kswang1029 added the bug Something isn't working label Aug 30, 2022
@pford pford self-assigned this Oct 18, 2022
@pford pford added this to the v4.0-b1 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants