Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image fitting: MAD calculation of images with nans #1318

Closed
YuHsuan-Hwang opened this issue Oct 11, 2023 · 0 comments · Fixed by #1319
Closed

Image fitting: MAD calculation of images with nans #1318

YuHsuan-Hwang opened this issue Oct 11, 2023 · 0 comments · Fixed by #1319
Assignees
Labels
bug Something isn't working

Comments

@YuHsuan-Hwang
Copy link
Contributor

YuHsuan-Hwang commented Oct 11, 2023

Describe the bug
(Found by @acdo2002) The MAD (median absolute deviation) calculation becomes lower when more additional nans are included in the fitting data. When std is 0 (with a large number of nans), the fitting fails.

Screenshots or videos
image

To Reproduce
Steps to reproduce the behavior:

  1. Fit the entire image and the fitting fails.

Expected behavior
The MAD calculation does not change when additional nans are included (and the fitting result does not change).
Fitting the entire image does not fail.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Big Sur
  • Browser [e.g. chrome, safari, electron app]: chrome
  • Browser version [e.g. 22]: 117
  • Backend branch [e.g. dev, v3b2 release]: dev, v4
  • Frontend branch [e.g. dev, v3b2 release]: dev, v4

Additional context
Download test image

@YuHsuan-Hwang YuHsuan-Hwang self-assigned this Oct 11, 2023
@YuHsuan-Hwang YuHsuan-Hwang added the bug Something isn't working label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant