-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yuhsuan/895 hypercube types #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to avoid putting anything in Util
unnecessarily -- it should only be required if a function is used in multiple files which do not and should not depend on each other.
GetCasaStokesType
is only used by StokesFilesConnector
, so I think that it should be defined in that header (and if we do decide to put it in Util
, for consistency it should go in Util/Casacore
).
ConvertFitsStokesValue
could be defined in the FileLoader
header, since StokesFilesConnector
imports it.
Apart from that, I think this all looks good.
…kesValue() to FileLoader
@confluence I moved the functions to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works well 👍
This PR is for the second part of #895:
apply a general check of the FITS stokes axis;
convert
CARTA::PolarizationType
tocasacore::Stokes
;apply error handling for
stokesCoordinate()
.allow
CTYPE
to be "Stokes" or "stokes" for CASA and FITS images;get stokes indices using
CRPIX
,CRVAL
, andCDELT
to correctly read headers withCRPIX != 1
;convert FITS index to
CARTA::PolarizationType
.requires frontend branch:
yuhsuan/1606_hypercube_types