Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrappers to construct protocol buffer messages where possible #960

Closed
confluence opened this issue Nov 10, 2021 · 0 comments · Fixed by #1125
Closed

Use wrappers to construct protocol buffer messages where possible #960

confluence opened this issue Nov 10, 2021 · 0 comments · Fixed by #1125
Assignees
Labels
code maintenance For issues relating to code maintenance and quality

Comments

@confluence
Copy link
Collaborator

Some wrappers for constructing protocol buffer messages in a more shorthand way were recently added to Util/Message. There are many places in the code where we could be using these wrappers instead of the more verbose multi-line syntax for filling in one field at a time (apart from the cases where we deliberately construct the message in multiple stages).

@kswang1029 kswang1029 added this to the v3.0b-3 milestone Jan 9, 2022
@veggiesaurus veggiesaurus added the code maintenance For issues relating to code maintenance and quality label Jan 12, 2022
@kswang1029 kswang1029 removed this from the v3.0b-3 milestone Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code maintenance For issues relating to code maintenance and quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants