Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelDescription.xml is not extracted when the FMU is a zip file #632

Closed
srdg opened this issue Dec 16, 2023 · 1 comment
Closed

modelDescription.xml is not extracted when the FMU is a zip file #632

srdg opened this issue Dec 16, 2023 · 1 comment

Comments

@srdg
Copy link

srdg commented Dec 16, 2023

According to the FMI standard, the FMU file would have the following folder structure :

--- binaries
--- resources
--- ....
--- modelDescription.xml

This line of code in simulation does not extract the modelDescription.xml file when the FMU is an archive, but retains the structure if the path given is that of an unzipped folder. This does not make sense!
The FMU structure should be maintained regardless of whether or not the file is an archive.
This leads to an error in most simulators, unless there is an explicit fallback to look for the modelDescription.xml in the resources folder by the FMI2Interface.dll ( in my case).
Kindly add the condition to also extract modelDescription.xml file if it is present at the root location. To do so, I think just adding modelDescription.xml in the required_paths list should suffice.

@t-sommer
Copy link
Contributor

An FMI 2.0 FMU must not make any assumptions about the directory structure outside the path supplied by fmuResourceLocation. Even the binaries may be extracted to a different directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants