feat(ui): highlight shapes that can currently be placed #55
Conversation
| @@ -198,6 +198,10 @@ class GameController : Controller() { | |||
| } | |||
| subscribe<HumanMoveRequest> { event -> | |||
| logger.debug("Human move request") | |||
|
|
|||
| val moves = GameRuleLogic.getPossibleMoves(event.gameState) | |||
| logger.debug("total: ${moves.size}") | |||
There was a problem hiding this comment.
Remove the debug output or make the message more verbose so that it will be useful in the future.
There was a problem hiding this comment.
ah, yeah, my bad.
I used to print the whole list before, but removed that because it was too noisy.
I'll update it; it's useful for debugging
| @@ -198,6 +198,10 @@ class GameController : Controller() { | |||
| } | |||
| subscribe<HumanMoveRequest> { event -> | |||
| logger.debug("Human move request") | |||
|
|
|||
| val moves = GameRuleLogic.getPossibleMoves(event.gameState) | |||
There was a problem hiding this comment.
Could we reduce that to a set of possible shapes here, so that the check below doesn't have to go through all moves for every shape?
There was a problem hiding this comment.
yeah, I did that meanwhile.
Still, had to wait for the other PR
|
yes, exactly, after the other one is merged. |
anarchuser
force-pushed
the
feat/highlight-fitting-pieces
branch
from
71e6647
to
99eb293
Compare
|
This doesn't work properly yet due to a bug. |
anarchuser
force-pushed
the
feat/highlight-fitting-pieces
branch
from
99eb293
to
3fcbf56
Compare
No description provided.