Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): use updated color validity check #59

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

anarchuser
Copy link
Contributor

@anarchuser anarchuser commented Nov 27, 2020

Follow-up to software-challenge/backend#333

Note: requires #333 to be merged and backend submodule to be updated
accordingly

Note: requires #333 to be merged and backend submodule to be updated
accordingly
@xeruf xeruf changed the title fix(ui): use correct color validity check following #333 changes fix(ui): use updated color validity check Dec 8, 2020
@xeruf
Copy link
Member

xeruf commented Dec 8, 2020

image

With backend on latest master, where 333 is already merged, I get this

@xeruf
Copy link
Member

xeruf commented Dec 8, 2020

I get the error 4 times before every move I do.

@xeruf xeruf changed the title fix(ui): use updated color validity check fix(controller): use updated color validity check Dec 8, 2020
@xeruf
Copy link
Member

xeruf commented Dec 8, 2020

btw, this has nothing to do with the ui

@xeruf xeruf marked this pull request as ready for review December 8, 2020 10:19
@xeruf xeruf merged commit 6c7f6cd into master Dec 8, 2020
@xeruf xeruf deleted the fix/unplayable-notice branch December 8, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants