Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve PFH with EachFrame mission event #303

Merged
merged 3 commits into from
Mar 27, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 27, 2016

  • this PR moves CBA_common_fnc_onFrame to the new EachFrame mission event handler from 1.58. To keep back wards compatibility with the 1.54 version the Linux build is using, it falls back to BIS_fnc_addStackedEventHandler if an older version of the game was detected. It also deletes "ancient" code that is no longer necessary.
  • deletes trigger that was detecting if onEachFrame command was used which would overwrite the BIS stacked event handler. no longer needed as EachFrame mission event is stackable and should be used instead. The trigger will still be created for older builds before 1.58.
  • deletes method that was using onDraw in case BIS_fnc_addStackedEventHandler wasn't defined (unreachable code and no longer necessary after EachFrame)
  • deletes CBA_Dummy_Map and CBA_FrameHandlerTitle because they are no longer used. Behaviour could also be emulated with RscMapControlEmpty + ctrlCreate without doing any config stuff, but I see no use for this after EachFrame was added
  • deletes cba_common_fnc_addPerFrameHandlerLogic and associated "blaHandler". These were unreachable code and probably meant to serialize the old old onDraw PFH method (which was used even before stacked event handlers)

@commy2 commy2 changed the title improve PFH with EachFrame mission event [wip] improve PFH with EachFrame mission event Mar 27, 2016
@commy2 commy2 added the WIP label Mar 27, 2016
@commy2 commy2 removed the WIP label Mar 27, 2016
@commy2 commy2 changed the title [wip] improve PFH with EachFrame mission event improve PFH with EachFrame mission event Mar 27, 2016
@Killswitch00 Killswitch00 merged commit 2bf6313 into master Mar 27, 2016
@thojkooi thojkooi deleted the improvePFHwithEachFrameMissionEvent branch April 25, 2016 11:32
@commy2 commy2 added this to the 2.3.2 milestone May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants