Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only allow logged in admins to change settings #448

Merged
merged 3 commits into from Aug 6, 2016

Conversation

Projects
None yet
4 participants
@commy2
Copy link
Contributor

commented Jul 30, 2016

When merged this pull request will:

  • This PR makes it so only logged in admins can change server settings as opposed to voted in admins as well.

@commy2 commy2 added the Bug Fix label Jul 30, 2016

@commy2 commy2 added this to the 3.0.1 milestone Jul 30, 2016

@@ -58,8 +58,10 @@
#define MENU_OFFSET_COLOR 1.0
#define MENU_OFFSET_COLOR_NEG -0.7

#define IS_ADMIN serverCommandAvailable "#shutdown"

This comment has been minimized.

Copy link
@Dorbedo

Dorbedo Jul 30, 2016

Contributor

maybe put a version of this macro in "script_macros_common.hpp"?
could be useful elsewhere

@Killswitch00

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2016

So, any macro addition as suggested by Dorbedo?

@commy2

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2016

done
IS_ADMIN and IS_ADMIN_LOGGED

@thojkooi

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2016

Build failure is not related to this PR.

@Killswitch00 Killswitch00 merged commit f0c2ac8 into master Aug 6, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Killswitch00 Killswitch00 deleted the settings-only-logged-admins branch Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.