-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVEMENT] Remove the need for the push to be on the master branch #1231
[IMPROVEMENT] Remove the need for the push to be on the master branch #1231
Conversation
This is because contributors don't have branches called master it isn't possible to manually trigger workflows as suggested by https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/m-p/31517. Also removed the workflow file from the path as it is implicitely set.
a06167c
to
88830e6
Compare
But now they're all in here twice.... |
That's a bug because I rebased like a mad. Shouldn't happen normally. (And shouldn't happen on a normal rebase) |
Why not show by making a new PR? :) |
PR's trigger the long running tests. And you might not want to make a PR for many reasons. |
I meant closing this one and creating a new one without the force-pushing this time so it's not showing up twice ;) And I'll just cancel the other ones. |
PR before your change: |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
This is because contributors don't have branches called master it isn't
possible to manually trigger workflows as suggested by
https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/m-p/31517.
My familiarity with the project is as follows (check one):