Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Remove the need for the push to be on the master branch #1231

Merged

Conversation

NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Feb 15, 2020

This is because contributors don't have branches called master it isn't
possible to manually trigger workflows as suggested by
https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/m-p/31517.

My familiarity with the project is as follows (check one):

  • I absolutely hate CCExtractor, but have not contributed previously. 😂 (just kidding)

This is because contributors don't have branches called master it isn't
possible to manually trigger workflows as suggested by
https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/m-p/31517.

Also removed the workflow file from the path as it is implicitely set.
@NilsIrl NilsIrl force-pushed the remove_branch_specification branch 2 times, most recently from a06167c to 88830e6 Compare February 15, 2020 22:16
@canihavesomecoffee
Copy link
Member

But now they're all in here twice....

@NilsIrl
Copy link
Contributor Author

NilsIrl commented Feb 15, 2020

But now they're all in here twice....

That's a bug because I rebased like a mad. Shouldn't happen normally. (And shouldn't happen on a normal rebase)

@canihavesomecoffee
Copy link
Member

Why not show by making a new PR? :)

@NilsIrl
Copy link
Contributor Author

NilsIrl commented Feb 15, 2020

Why not show by making a new PR? :)

PR's trigger the long running tests. And you might not want to make a PR for many reasons.

@canihavesomecoffee
Copy link
Member

I meant closing this one and creating a new one without the force-pushing this time so it's not showing up twice ;)

And I'll just cancel the other ones.

@NilsIrl
Copy link
Contributor Author

NilsIrl commented Feb 15, 2020

I meant closing this one and creating a new one without the force-pushing this time so it's not showing up twice ;)

PR before your change:

https://github.com/CCExtractor/ccextractor/pull/1226/checks

@canihavesomecoffee canihavesomecoffee merged commit 588c4a8 into CCExtractor:master Feb 15, 2020
@NilsIrl NilsIrl deleted the remove_branch_specification branch February 15, 2020 23:08
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 32/34
CEA-708 14/14
DVD 3/3
Options 82/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants