Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Remove the need for the push to be on the master branch #1231

Merged

Conversation

@NilsIrl
Copy link
Contributor

NilsIrl commented Feb 15, 2020

This is because contributors don't have branches called master it isn't
possible to manually trigger workflows as suggested by
https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/m-p/31517.

My familiarity with the project is as follows (check one):

  • I absolutely hate CCExtractor, but have not contributed previously. 馃槀 (just kidding)
This is because contributors don't have branches called master it isn't
possible to manually trigger workflows as suggested by
https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/m-p/31517.

Also removed the workflow file from the path as it is implicitely set.
@NilsIrl NilsIrl force-pushed the NilsIrl:remove_branch_specification branch 2 times, most recently from a06167c to 88830e6 Feb 15, 2020
@canihavesomecoffee

This comment has been minimized.

Copy link
Member

canihavesomecoffee commented Feb 15, 2020

But now they're all in here twice....

@NilsIrl

This comment has been minimized.

Copy link
Contributor Author

NilsIrl commented Feb 15, 2020

But now they're all in here twice....

That's a bug because I rebased like a mad. Shouldn't happen normally. (And shouldn't happen on a normal rebase)

@canihavesomecoffee

This comment has been minimized.

Copy link
Member

canihavesomecoffee commented Feb 15, 2020

Why not show by making a new PR? :)

@NilsIrl

This comment has been minimized.

Copy link
Contributor Author

NilsIrl commented Feb 15, 2020

Why not show by making a new PR? :)

PR's trigger the long running tests. And you might not want to make a PR for many reasons.

@canihavesomecoffee

This comment has been minimized.

Copy link
Member

canihavesomecoffee commented Feb 15, 2020

I meant closing this one and creating a new one without the force-pushing this time so it's not showing up twice ;)

And I'll just cancel the other ones.

@NilsIrl

This comment has been minimized.

Copy link
Contributor Author

NilsIrl commented Feb 15, 2020

I meant closing this one and creating a new one without the force-pushing this time so it's not showing up twice ;)

PR before your change:

https://github.com/CCExtractor/ccextractor/pull/1226/checks

@canihavesomecoffee canihavesomecoffee merged commit 588c4a8 into CCExtractor:master Feb 15, 2020
11 of 16 checks passed
11 of 16 checks passed
format format
Details
format format
Details
build_shell
Details
build_shell
Details
build
Details
build
Details
build_autoconf
Details
build_autoconf
Details
cmake
Details
cmake
Details
cmake_ocr_hardsubx
Details
cmake_ocr_hardsubx
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
CI - linux Tests queued
Details
CI - windows Tests queued
Details
WIP Ready for review
Details
@NilsIrl NilsIrl deleted the NilsIrl:remove_branch_specification branch Feb 15, 2020
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Feb 15, 2020

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 32/34
CEA-708 14/14
DVD 3/3
Options 82/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.