Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Bad log_dir in hil.cfg crashes server #976

Closed
ianballou opened this issue Mar 13, 2018 · 4 comments
Closed

Bad log_dir in hil.cfg crashes server #976

ianballou opened this issue Mar 13, 2018 · 4 comments
Assignees
Milestone

Comments

@ianballou
Copy link
Contributor

If log_dir is set to something inappropriate, the server will crash an report Unexpected error:.
This error should report something more useful to the user. After this is fixed, perhaps it could be added to the config precheck (#966)

@zenhack
Copy link
Contributor

zenhack commented Mar 14, 2018

Poked at this a little bit, this should be a simple matter of catching IOError specifically in the cli and handling it. we'll want to wait until #969 is merged though, since it will likely cause conflicts.

@naved001
Copy link
Contributor

Wouldn't what I suggest here fix this?

@ianballou
Copy link
Contributor Author

ianballou commented Mar 15, 2018

It could still crash if the directory can't be accessed. The config check in #966 will only check for malformed directories, not if they exist or not.
I do think configuring logging after validating the config file is a good idea though.

@naved001 naved001 added this to the 0.4 milestone Mar 21, 2018
@naved001 naved001 added the easy label Mar 21, 2018
@naved001
Copy link
Contributor

Fixed by #966

@naved001 naved001 modified the milestones: 0.4, 0.3 Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants