Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major bug: sign error in PhaseErrrorCorrectALS #84

Closed
CCampJr opened this issue Sep 17, 2019 · 1 comment
Closed

Major bug: sign error in PhaseErrrorCorrectALS #84

CCampJr opened this issue Sep 17, 2019 · 1 comment

Comments

@CCampJr
Copy link
Owner

CCampJr commented Sep 17, 2019

Unfortunately, there has been a long-standing sign error in the PhaseErrorCorrectALS class that I did not catch. This would primarily be noticeable if looking at the real part of spectra. The imaginary portion is less likely to show much of a difference.
@CCampJr
Copy link
Owner Author

CCampJr commented Sep 17, 2019

Fixed in 1238e48

@CCampJr CCampJr closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CCampJr