Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to change class on <html> element #50

Closed
jduss4 opened this issue Apr 14, 2017 · 6 comments
Closed

add ability to change class on <html> element #50

jduss4 opened this issue Apr 14, 2017 · 6 comments
Assignees
@karindalziel @jduss4 @techgique
Labels
orchid

Comments

@jduss4
Copy link
Contributor

jduss4 commented Apr 14, 2017

pages should know their identity and be able to pass controller variable to set class so Karin can use one stylesheet
@jduss4 jduss4 added the orchid label Apr 14, 2017
@jduss4
Copy link
Contributor Author

jduss4 commented Apr 14, 2017

I recall this was trouble with turbolinks or some other rails caching type of mechanism, specifically with the neihardt version of the site, but I have no idea if Rails 5 can handle it or if other things have changed about how the pages are rendered which would mean this works out better. Should revisit.

Example:
https://github.com/CDRH/neihardt/blob/master/app/views/layouts/application.html.erb#L2

@karindalziel
Copy link
Member

Debating on whether this should always be explicitly set (i.e. passing through a variable from the view) OR if it should be entirely based on the URL. In cocoon I mostly depended on routes/url's. I'd set the home page explicitly:

<html class="home">

and then all the other pages I'd set by the first part of the URL:

www.whatever.org/*/**/***.html

* above = the text that gets inserted as a class name

To be more future proof, we may want to prepend something to make sure that class names don't collide with any framework classes. so maybe

site_home
site_about
site_writings

etc.

Thoughts?

@karindalziel
Copy link
Member

We had a brief discussion about the feasibility of including this based on the url - for most sites, I think this would be enough, though being able to overwrite from a view would also certainly be useful.

@techgique
Copy link
Member

Another option may be to use the controller name, params[:controller], similarly to how it is described here: http://edgeguides.rubyonrails.org/asset_pipeline.html#controller-specific-assets

@techgique techgique mentioned this issue Apr 26, 2017
Merged
@jduss4
Copy link
Contributor Author

jduss4 commented May 4, 2017

I vaguely recall trying to use the controller previously for the Neihardt test run and it didn't have as fine of control as Karin was looking for. Maybe controller + action?

@jduss4
Copy link
Contributor Author

jduss4 commented May 15, 2017

Closing this because I opened it on the orchid repository at CDRH/orchid#15

@jduss4 jduss4 closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karindalziel karindalziel

@jduss4 jduss4

@techgique techgique

Labels
orchid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karindalziel @jduss4 @techgique