Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Scene integration #32

Open
Scaby79 opened this issue Apr 4, 2023 · 6 comments
Open

Problems with Scene integration #32

Scaby79 opened this issue Apr 4, 2023 · 6 comments

Comments

@Scaby79
Copy link

Scaby79 commented Apr 4, 2023

As soundscape is integrated in the scene configuration you can add a soundscape in the ambient tab of the scene configuration.
When you do, it loads perfectly, when a scene is activated but it DOESN'T STOP, when another scene is activated.

Using a title of a playlist or a whole playlist (instead of a soundscape) on the other hand DOES STOP, when you change an active scene so I thought this is worth an issue here.

It would be very nice if that could be fixed if possible.

@CDeenen
Copy link
Owner

CDeenen commented Apr 23, 2023

I just released an update and this should now be fixed

@CDeenen CDeenen closed this as completed Apr 23, 2023
@Scaby79
Copy link
Author

Scaby79 commented May 17, 2023

Sorry, but the problem still persists.

@Scaby79
Copy link
Author

Scaby79 commented May 17, 2023

I just released an update and this should now be fixed

The last release didn't fix the issue.

@CDeenen CDeenen reopened this May 18, 2023
@CDeenen
Copy link
Owner

CDeenen commented May 18, 2023

You're right, this isn't fixed. Very strange, I'm sure I tested it multiple times.
I'll have another look at it...

@CDeenen
Copy link
Owner

CDeenen commented Jun 28, 2023

Please give the latest version another try, it hopefully works now

@Scaby79
Copy link
Author

Scaby79 commented Jul 12, 2023

I just tested the Version 1.1.1 of your module in a world in FVTT version 10.291.
It is not working entirely as it should:

If you are switching to a scene where there is another soundscape set, the soundscape of the scene you are leaving is stopped as intended.

If you are switching to a scene with no soundscape set (either because there is a single sound or a playlist or no sound at all set via the core settings option) the soundscape is not always* stopping.

*comment for the "not always":
The default option in the soundscape section of the scene configuration apparently is "Unchaged". With this option selected, a soundscape does NOT stop, when leaving a scene.
If the option "None" in the soundscape section of the scene configuration is set, the soundscape of the scene that is just left DOES actually stop (just as intended).
BUT: The selected option in the soundscape section of the scene configuration automatically switches back to "Unchanged" (at least when opening the configuration dialog) and even if this change isn't confrmed or saved, stopping the soundscape is not working anymore (in other words: it breaks again)!

Suggested solution:
Maybe setting the default option in the soundscape section of the scene configuration to "None" instead of "Unchanged" could solve the problem for good?

Hope that helps and enables you to fix it.

Thx for your effort. I love your module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants