Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in applying adjustment factors by representative county in Movesmrg. #105

Open
hnqtran opened this issue Aug 1, 2024 · 1 comment
Open
Assignees

Comments

@hnqtran
Copy link
Contributor

hnqtran commented Aug 1, 2024

This bug is part of the issues described in the ticket #104.

When applying adjustment factors by representative county (USE_REF_CONTROL_FAC_YN = Y) in Movesmrg: if there is a group in which a rep county is mapped to several counties, where the rep county itself has no activity (which can happen with hoteling / RPH in particular) but other counties in the rep county group do have activity, then the adjustments are not applied to the other counties in the rep county group.

@hnqtran hnqtran self-assigned this Aug 1, 2024
@callen52
Copy link

Here are some example SMOKE-MOVES inputs to test with. I recommend testing with RPH. You can take most other onroad inputs that you would need for testing from 2022 platform (https://gaftp.epa.gov/air/emismod/2022/v1/)

HOTELING_2022v1_2026hc_MOVES4_25jul2024_nf_v1.csv - This is hoteling activity for 2026 (but can be used with the posted inputs from 2022 for testing purposes). Note that county 55075 has no activity in this dataset, but other counties in the 55075 reference county group do have activity, e.g. 55005.

cfpro_2026hc_MOVES4_OTAQrules_annual_RPH_26jul2024_v0.csv - Here is a CFPRO file we have been using for 2026, which applies factors by reference county (USE_REF_CONTROL_FAC_YN = Y). County 55075 is a reference county and is listed here. But what I am finding it that since 55075 itself has no hoteling activity, these factors are not applied to any of the counties in the ref county group which do have hoteling activity (e.g. in county 55005).

HOTELING_2022v1_dummy_bug_workaround_30jul2024_v0.csv - This is an additional hoteling activity dataset which I included in my SMOKE-MOVES run as a workaround, and which includes a very tiny amount of activity in county 55075, among other ref counties with this issue. When I include this in the SMOKE-MOVES run, the CFPRO factors for 55075 are properly applied to the entire ref county group.

Monthly_onroad_RPH_12US1_2026hc_cb6_22m_20240730111852.csh.txt - Our run script, in case there are any questions about parameter settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants