Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Geometry #125

Open
mdzik opened this issue Dec 19, 2016 · 1 comment
Open

Cleanup Geometry #125

mdzik opened this issue Dec 19, 2016 · 1 comment
Labels
enhancement New features/updates question Question regarding the code
Milestone

Comments

@mdzik
Copy link
Member

mdzik commented Dec 19, 2016

in the same manner as Handlers

Other ideas/suggestions?

I think we don't need geometry objects, but it might be usable in future for DOM handling.
I would convert present long if-else into calls for static methods of proper classes:

    } else if (strcmp(n.name(), "OffgridSphere") == 0) {
/// a lot of code

to

    } else if (strcmp(n.name(), "OffgridSphere") == 0) {
      OffgridSphere::Render(args)

or even

    } else if ( OffgridSphere::IsThisMe(n) ) {
      OffgridSphere::Render(args)
@mdzik mdzik added enhancement New features/updates question Question regarding the code labels Dec 19, 2016
@llaniewski
Copy link
Member

I think we can think on this, or a full DOM-like thing in next version (V6.2). I want to clean up most important things before V6.1 RC and get it back on track on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features/updates question Question regarding the code
Projects
None yet
Development

No branches or pull requests

2 participants