Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #8515 Spelling mistakes found checking en-GB to en-US #8522

Merged
merged 1 commit into from
Oct 21, 2024
Merged

issue #8515 Spelling mistakes found checking en-GB to en-US #8522

merged 1 commit into from
Oct 21, 2024

Conversation

albert-github
Copy link
Contributor

The "bib" part.
(checked as well as possible against google and mostly science direct as well)

@albert-github
issue CGAL#8515 Spelling mistakes found checking en-GB to en-US
3e57259 
The "bib" part.
(checked as well as possible against google and mostly science direct as well)
@albert-github albert-github mentioned this pull request Oct 6, 2024
Open
@afabri
Copy link
Member

afabri commented Oct 6, 2024

Concerning the bib part, I am wondering if it has an upstream source. Olivier ( @odevil ) do you know?

@afabri afabri added this to the 6.1-beta milestone Oct 7, 2024
@lrineau lrineau added the Not yet approved The feature or pull-request has not yet been approved. label Oct 9, 2024
@sloriot
Copy link
Member

sloriot commented Oct 14, 2024

Successfully tested in CGAL-6.0.1-Ic-345

@lrineau
Copy link
Member

lrineau commented Oct 14, 2024

Concerning the bib part, I am wondering if it has an upstream source. Olivier ( @odevil ) do you know?

The historical web site is still available at https://jeffe.cs.illinois.edu/compgeom/biblios.html. The geom.bib file their dates from November 1998.

Jeff Erickson still has a copy of it at https://github.com/jeffgerickson/bib/ with new formatting and a few personal addition.

@albert-github
Copy link
Contributor Author

nice reference.

@lrineau

  • how did you compare the cgal geom.bib with the one from Jeff Erickson?

Looks like there is not al lot of development and the changes in CGAL are, in my opion, correct so they should be mentioned to / added to the original source as well (when there is interest).

  • What do you suggest?

@afabri
Copy link
Member

afabri commented Oct 21, 2024

I suggest that we keep the fixes in our fork. If interested we leave it to @jeffgerickson to backport fixes.

@sloriot sloriot added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed Not yet approved The feature or pull-request has not yet been approved. Ready to be tested labels Oct 21, 2024
@sloriot sloriot merged commit ce2fcc0 into CGAL:master Oct 21, 2024
8 checks passed
@albert-github albert-github deleted the feature/issue_8515_2 branch October 21, 2024 17:29
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri approved these changes

Assignees
No one assigned
Labels
Doc Tested
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@albert-github @afabri @sloriot @lrineau