Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need runtime interface to query if queue uses immediate command list. #694

Closed
Sarbojit2019 opened this issue Nov 21, 2023 · 2 comments
Closed

Comments

@Sarbojit2019
Copy link
Collaborator

oneAPI 2024.0.0 has changed the interface of make_queue() which is used for interop. New interface now takes isImmCmdList as one of the argument hence chipStar runtime has to have an interface to query the same info.

queue make_queue(const context &Context, const device &Device,
pi_native_handle InteropHandle,
bool IsImmCmdList, bool keep_ownership,
const property_list &Properties);

chipStar can plan to implement get_native similar to SYCL which returns std::variant. Variant will be object of type ze_command_list_handle_t for ICL and ze_command_queue_handle_t otherwise.

For example:
std::variant<ze_command_queue_handle_t, ze_command_list_handle_t> queue_var_handle =
get_nativesycl::backend::level_zero(queue)

@Sarbojit2019
Copy link
Collaborator Author

Above ask is to fix ticket : CHIP-SPV/H4I-MKLShim#17.

@pvelesko
Copy link
Collaborator

Even when using ICL, we can still return the command queue. We can thus always set isImmCmdList = false which is what we do now and interop seems to work.

Please reopen the issue if there is a legitimate need to use ICL with interop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants