Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask restoring variables #149

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Conversation

eclare108213
Copy link
Contributor

The restoring variables needed to be masked by land, and restart_ext must be true when using open boundaries, so that the halo cells are saved in the restart files.

  • Developer(s): E. Hunke

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? BFB except for the test that was failing.

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N
    Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
    which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:
    Addresses issue boxrestart test is failing exact restart #138. I still need to run the base_suite.

Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine, why is travis failing?

@eclare108213
Copy link
Contributor Author

travis is failing on the builds because I'm multiplying real arrays by tmask, which is a logical array. I need to use hm instead, or convert tmask to real (double) locally.

@eclare108213
Copy link
Contributor Author

@apcraig, this should be ready to merge now

@apcraig apcraig merged commit f309506 into CICE-Consortium:master Jun 19, 2018
@eclare108213 eclare108213 deleted the boxrestore branch October 28, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants