Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDC-1646 fix counting bug #798

Merged
merged 2 commits into from
Mar 16, 2023
Merged

CIDC-1646 fix counting bug #798

merged 2 commits into from
Mar 16, 2023

Conversation

scvannost
Copy link
Collaborator

What

Fix counting bug where WES tumor-only assay counting can be affected by repeated IDs in other trials.

Why

Discovered in validation of Essex testing data on staging.

How

Restrict join to be also on trial_id

Remarks

  • Did not add test to prevent reversion
  • Did not check for other counting subqueries for similar effects

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - README and CHANGELOG have been updated to explain major changes & new features
  • Package version - Manually bumped the API package version in init.py

@scvannost scvannost merged commit 4194681 into master Mar 16, 2023
@scvannost scvannost deleted the counting-bug branch March 16, 2023 16:49
@scvannost scvannost mentioned this pull request Mar 28, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants