Make building with debuginfo optional #33
Conversation
|
Needs a rebase. |
major
force-pushed
the
issue-14-disable-debuginfo
branch
from
5731788
to
44879b3
Compare
|
@stefwalter Done! |
|
Just a cross check on the default here. So I'm interested in the "why" ... do you expect building a kernel without debuginfo to be routine and normal case for SKT runs? If not, why is it the default? Does a non-debuginfo kernel significantly increase the difficulty of diagnosing a test failure? @dzickusrh @veruu Any comments? |
skt/__init__.py
Outdated
| if not self.enable_debuginfo: | ||
| logging.info("disabling debuginfo:") | ||
| args = shlex.split('script/config --disable debug_info') | ||
| subprocess.check_call(args) |
There was a problem hiding this comment.
This should probably just be:
subprocess.check_call(['script/config', '--disable', 'debug_info'])
And drop the shlex usage? What do you think?
There was a problem hiding this comment.
I'm not opposed, but shlex is usually my go-to for increasing readability. ;)
I'll change it.
Based on my experience, debug info is only useful if you want to run the resulting image through |
|
Sounds like defaulting to without debuginfo makes sense. |
major
force-pushed
the
issue-14-disable-debuginfo
branch
from
44879b3
to
9974d65
Compare
|
Okay, the patch is updated. I also added a quick note in the |
|
This comment is a little late, but just to add to it. I agree with Veronika, for the most part debuginfo isn't useful. The only piece in there that folks use is 'vmlinux' to feed into crash. Most local builds we strip out the debug symbols to massively reduce the size. |
| # final kernel tarball size by 3-4x and can increase build time | ||
| # slightly. Debug symbols are really only needed for deep diagnosis | ||
| # of kernel issues on a specific system. This is why debuginfo is | ||
| # disabled by default. |
There was a problem hiding this comment.
Hey, nice touch with the comment :)
| cfg.get('cfgtype'), | ||
| cfg.get('makeopts'), | ||
| cfg.get('enable_debuginfo') | ||
| ) |
There was a problem hiding this comment.
This is getting a little out of hand. We'll need to convert this to named arguments next.
There was a problem hiding this comment.
Agreed. I can work on that. Created #42 for that.
skt/executable.py
Outdated
| "--enable-debuginfo", | ||
| type=bool, | ||
| default=False, | ||
| help="build kernel with debuginfo (default: disabled)" |
There was a problem hiding this comment.
Could you please start the help text with a capital letter to match the rest?
By default, kernels are built with debug symbols. This increases the build time and the size of the resulting tarball. tar.gz with debug symbols: ~ 250MB tar.gz without debug symbols: ~ 75MB If debug symbols are really needed for diagnosing a tough problem, the user can specify `--enable-debuginfo` when calling `skt build`. Closes cki-project#32.
major
force-pushed
the
issue-14-disable-debuginfo
branch
from
9974d65
to
702a976
Compare
|
Thank you, Major :)! |
By default, kernels are built with debug symbols. This increases the
build time and the size of the resulting tarball.
If debug symbols are really needed for diagnosing a tough problem,
the user can specify
--enable-debuginfowhen callingskt build.Fixes #32.
Signed-off-by: Major Hayden major@redhat.com