Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

db.get_sourceid should use a transaction or have no ID creation #73

Open
spbnick opened this issue Jun 5, 2018 · 0 comments
Open

db.get_sourceid should use a transaction or have no ID creation #73

spbnick opened this issue Jun 5, 2018 · 0 comments

Comments

@spbnick
Copy link
Contributor

spbnick commented Jun 5, 2018

At the moment db.get_sourceid is prone to a race condition between checking if a source ID exists and creating one. It should either use a transaction (but that complicates the logic since create_sourceid is also a public function which can also create a transaction), or better just have no ID creation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant