Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Style tags are duplicated in head #23

Open
CLeeSpruit opened this issue Jan 22, 2020 · 2 comments
Open

[BUG] Style tags are duplicated in head #23

CLeeSpruit opened this issue Jan 22, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@CLeeSpruit
Copy link
Owner

CLeeSpruit commented Jan 22, 2020 •
edited
Loading

Describe the bug
When adding a component with a style attached, it's properly appended to the head, but there's also an extra sibling element that's garbage.
image

Bug is likely located in the Component.createNodes() section. If I had to guess, the function might be running multiple times and not grabbing the correct existing element.
https://github.com/CassandraSpruit/Vivi/blob/20dd2ace8115d6bedc2995463601f02967c19e2c/src/models/component.js#L85
@CLeeSpruit CLeeSpruit added the bug Something isn't working label Jan 22, 2020
This was referenced Feb 4, 2020
Open
Closed
Merged
@CLeeSpruit
Copy link
Owner Author

This still exists in v5.2.6.

@CLeeSpruit
Copy link
Owner Author

BTW this issue happens to any component that has a template, no matter how it's been added, unlike the bug in #30 (which only happens when called with createChild()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CLeeSpruit