Develop #7
Merged
Develop #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
= =首先。。。请先rebase。。。。 |
|
好的 我rebase一下 |
|
👍 |
| logging.BASIC_FORMAT = "%(asctime)s [%(name)s] %(message)s" | ||
| logging.basicConfig(level=level) | ||
| if self.config.log_file: | ||
| paramiko.util.log_to_file(self.config.log_file, level=level) |
There was a problem hiding this comment.
paramiko 的 log 能否都统一输出到 logging ，然后输出文件与否由 logging 的配置决定？ cc @CMGS
|
|
|
@waterdrinker gevent 的 worker 正常了么？ |
|
@waterdrinker 改一下 pull request 的 title 吧，比如 'Add maria command' 什么的 |
| # -*- coding: utf-8 - | ||
|
|
||
| try: | ||
| import gevent |
There was a problem hiding this comment.
默认-w sync不用gevent, 指定-w async才会导入这个模块
There was a problem hiding this comment.
我是说 gevent 这个module 在这个文件里面并没有用到
|
@xtao 这位也是参加OSC暑假的实习生吗？ |
|
@alexband 是的 |
|
@xtao Add maria/tests |
|
👍 |
| assert pclone.wait() == 0 | ||
|
|
||
| def test_push(self): | ||
| cmd = 'mkdir %s; \ |
waterdrinker
force-pushed
the
develop
branch
from
fe0bc6d
to
30fc48a
Compare
waterdrinker
force-pushed
the
develop
branch
from
30fc48a
to
682ad1b
Compare
|
... 这个 PR 被遗忘了么 |
|
去年的。。。 |
|
... 我今年又看到了这个... |
|
@tonicbupt 前年的 |
CMGS
added a commit
that referenced
this pull request
Dec 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Add maria/worker.
2 Fix command line interface: 1. -w sync(or async) 2. xxx.xxx:app
3 Add maria/tests