-
Notifications
You must be signed in to change notification settings - Fork 1
Project Part 3 Feedback
Code base of prototype: Excellent 3/3
Demo: Excellent 1/1
Code documentation: Good 1/1
Test cases: Satisfactory 1/2
OOD: Good 1/2
Release planning: Good 1/1
Addressing feedback: Excellent 1/1
In total: 9/11
This is based on the rubric in https://eclass.srv.ualberta.ca/mod/resource/view.php?id=326268. If you have any concerns please email me (chenlei.zhang AT ualberta.ca).
The team finished more than half of the project. The code looks clean and clear. It is nice to have different packages for storing model and view classes.
The team demoed their application in an interactive way with the TA which is cool. The application is demonstrable and clear to use.
The code documentation is mostly consistent and easy to interpret. However, the team didn't write the javadoc for several model classes.
There are some test cases but it is not enough. The test cases should test all the interface of the model. Besides, please add enough comments in your testing code too.
The diagram is good and includes most of the important classes. Model and data classes are obvious. It would be nicer to have the diagram well-labelled.
The release planning is clear. I suggest that you should add date information which could help the team keep track of the progress.
The feedback was addressed.