Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Change notification page length to 10 #1321

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

patrickseguraoddball
Copy link
Contributor

NOREF

Description

With the recent pagination conversion, notification page length was set to 3. This should be 10

How to test this change

  1. Notifications are listed as 10 per page

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner August 27, 2024 22:00
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and removed request for a team August 27, 2024 22:00
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple change!

@patrickseguraoddball patrickseguraoddball merged commit be25e52 into main Aug 28, 2024
11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the NOREF/notification-page-length branch August 28, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants