Sw/update velocity #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic framework of VelocityUpdater class, just applies constant acceleration to the buggy
Added velocity_updater node to launch file
Removed mpc_calculator node from launch file to remove terminal error message when running simulation
Added calculate_accel function to vary velocity over time (currently accelerates for 20s and then stops)
christianvluu
requested changes
Nov 16, 2023
Jackack
approved these changes
Nov 16, 2023
Jackack
previously requested changes
Nov 16, 2023
There was a problem hiding this comment.
Everything looks good but you need to pull the changes in main and merge them. Keep in mind that the topic names are remapped after the 2-buggy sim was merged into main. You will need to take the name of the buggy as a command line argument in your python file and prepend it to your topic paths. Consult the new 2d sim launch files for how to pass command line args via Roslaunch.
christianvluu
approved these changes
Nov 17, 2023
Velocity updater code now works for both simulating single buggies and 2 buggies
Jackack
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for automatically changing velocity over time based on checkpoints on track