Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more starting positions #63

Merged
merged 1 commit into from
Mar 28, 2024
Merged

added more starting positions #63

merged 1 commit into from
Mar 28, 2024

Conversation

Jackack
Copy link
Collaborator

@Jackack Jackack commented Mar 28, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

added more starting positions
added 15 second wait before short circuit moves -> this is required for MPC to properly initialize
increased sim noise

QA Instructions, Screenshots, Recordings

run roslaunch buggy sim_2d_2buggies.launch manual_vel:=true. Set short circuit velocity to 10 immediately. Short circuit position should show up immediately in foxglove, but only starts moving after 15 seconds.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: not easily testable with automated script, but easily testable by just running the sim.
  • I need help with writing tests

added 15 second wait before buggy moves
increased sim noise
Copy link
Collaborator

@christianvluu christianvluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks bueno

Copy link
Collaborator

@christianvluu christianvluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks bueno my bad hit the wrong button

@Jackack Jackack merged commit cf264d2 into main Mar 28, 2024
3 checks passed
@Jackack Jackack deleted the SimUpdates branch March 28, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants