Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AdoptJDK as workaround if Sentinel-3 images are upgraded #578

Closed
3 tasks
w-fsi opened this issue Sep 28, 2022 · 9 comments
Closed
3 tasks

Remove AdoptJDK as workaround if Sentinel-3 images are upgraded #578

w-fsi opened this issue Sep 28, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request WERUM dev Ticket dedicated to WERUM development

Comments

@w-fsi
Copy link

w-fsi commented Sep 28, 2022

User story description: _"As a [COPRS integrator] I need at least Java 11 in order to operate the IPF Execution Worker. However the S3 images are currently based on Centos 6 and it is not possible to retrieve a recent version from the official repositories.

Thus it was decided to use another binary java distribution as a workaround. AdoptJDK is currently pulled into the image:
RUN wget https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.16.1%2B1/OpenJDK11U-jdk_x64_linux_hotspot_11.0.16.1_1.tar.gz RUN tar -xf OpenJDK11U-jdk_x64_linux_hotspot_11.0.16.1_1.tar.gz && rm OpenJDK11U-jdk_x64_linux_hotspot_11.0.16.1_1.tar.gz

And a workaround is added to the start script of the execution worker in order to inject the Java Home via an environmental variable:
# Install java 11 - workaround for AdoptJDK RUN sed -i '1 a\export PATH=$PATH:/opt/jdk-11.0.16.1+1/bin' /app/start.sh

These modifications shall be removed once ESA providing a base image based on a more recent Centos version able to retrieve a suitable JVM from the official repositories.

"_

Acceptance criteria:

  • No AdoptJDK is used anymore
  • Workaround from Docker Files are removed
  • Execution Worker can be executed with a JVM from OS

Definition of Done The User Story is considered completed when...

  • Acceptance criteria are full filled
  • Other potential conditions
@w-fsi w-fsi added enhancement New feature or request WERUM dev Ticket dedicated to WERUM development labels Sep 28, 2022
@Woljtek
Copy link

Woljtek commented Jun 2, 2023

@w-fsi
We received the first S3 CFI images based on Centos 7.

You can have a look on F1:

The CFI are pushed on F2 and ready to integrated::

This images shall be incorporated on RS. I propose to use this US for incorporation in the next delivery. Do you agree ?

Moreover, we are interested in deploying and testing its quickly on production. If the updates don't impact the RS Add-on configuration, I would like to deploy the develop version of the execution-workers as soon as possible.

Note: We are still waiting for new Centos 7 images. Other updates may be added to the next delivery. I don't have any visibility.

@w-jka
Copy link

w-jka commented Jun 15, 2023

@Woljtek

We updated the container and chains on the develop-branch for the SR1 and MW1 chains. The workaround was removed for these IPF-containers.

The dynamic libraries and java 11 were successfully found and there were no additional changes in the task tables.

@Woljtek
Copy link

Woljtek commented Jun 21, 2023

Here below the last images to update:

SDP name OS 6 version OS 7 version Registry path
S3_OL1 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-ol1:06.17
S3_OL1_RAC 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-ol1-rac:06.15
S3_OL1_SPC 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-ol1-spc:06.12
S3_OL2 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-ol2:06.18
S3_PUG 3.09 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-pug:3.48
S3_SL1 3.04 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-sl1:06.23
S3_SL2 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-sl2:06.22
S3_SL2_FRP 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-sl2-frp:01.09
S3_SY2 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-sy2:06.26
S3_SY2_AOD 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-sy2-aod:01.09
S3_SY2_VGS 3.11 3.23 artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-sy2-vgs:06.13

@w-fsi w-fsi self-assigned this Jun 22, 2023
@w-jka
Copy link

w-jka commented Jun 22, 2023

@Woljtek
artifactory.coprs.esa-copernicus.eu/cfi/processors/sentinel3/s3-ol1-rac:06.15 is not uploaded to Artifactory

@Woljtek
Copy link

Woljtek commented Jun 22, 2023

I fixed OL1-RAC.
Also, I will add the L0 this afternoon

@w-fsi
Copy link
Author

w-fsi commented Jun 29, 2023

All mentioned IPFs was upgraded and OpenJDK removed.

@vgava-ads
Copy link

vgava-ads commented Jul 18, 2023

Delivered in Sentinel-3 v1.14.0 (https://github.com/COPRS/processing-sentinel-3/releases) and in Production Common v1.14.0 (refer to https://github.com/COPRS/production-common/releases)

@pcuq-ads
Copy link

SYS_CCB_w29 : All Sentinel-3 execution worker images have been provided with Centos 7 Operating System. This ticket can be closed.

@Woljtek
Copy link

Woljtek commented Jul 21, 2023

For information, the US includes only L1 and L2. The updates of L0 is handled:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WERUM dev Ticket dedicated to WERUM development
Projects
None yet
Development

No branches or pull requests

5 participants