Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate recipes of eddy-mean kinetic energy decomposition? #445

Closed
navidcy opened this issue Aug 27, 2024 · 2 comments · Fixed by #448
Closed

Duplicate recipes of eddy-mean kinetic energy decomposition? #445

navidcy opened this issue Aug 27, 2024 · 2 comments · Fixed by #448
Assignees

Comments

@navidcy
Copy link
Collaborator

navidcy commented Aug 27, 2024

Seems that we have ended up with two of these recipes...

https://cosima-recipes.readthedocs.io/en/latest/Recipes/Decomposing_kinetic_energy_into_mean_and_transient.html

https://cosima-recipes.readthedocs.io/en/latest/Recipes/Eddy-Mean_Kinetic_Energy_Decomposition.html

Let's combine those? Is one old/deprecated?

@anton-seaice
Copy link
Collaborator

Didn’t it get renamed in #418 ?

But then when #358 was done this was missed and it was recreated with the old name.

We can just delete the current Eddy-Mean_Kinetic_Energy_Decomposition and then rename Decomposing_kinetic_energy_into_mean_and_transient to Eddy-Mean_Kinetic_Energy_Decomposition

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 27, 2024

I believe some mess-up like that might have happened with merging main to previously opened PR or something...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants