Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion Compare_SST_SSS_TemperatureSalinity_to_WOA13 #355

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@marc-white
Copy link

marc-white commented Aug 30, 2024

The changes on this notebook are not complete - Cosima Cookbook is still being used. Moving to update.

@adele-morrison
Copy link
Collaborator

@marc-white yes as @julia-neme said, pretty much all of these PRs from @max-anu require substantial modification, not just reviewing. If you'd like to go ahead and make these changes to remove references to the cookbook in this notebook, please do! Many of us have run out of steam for dealing with these broken PRs.

@marc-white
Copy link

marc-white commented Aug 30, 2024

WOA13 data are also missing from intake, see ACCESS-NRI/access-nri-intake-catalog#190

@navidcy
Copy link
Collaborator

navidcy commented Aug 30, 2024

Feel free to close some of the PRs if data is missing and there is light at the end of the tunnel!

@julia-neme
Copy link
Collaborator

julia-neme commented Aug 30, 2024

Yeah, the recipes that use WOA for now load it manually from ik11. We can keep doing that.. or wait until the catalog is updated? I think we are moving away from using hh5 @marc-white , but woa13 is in /g/data/ik11/observations/woa13

@navidcy
Copy link
Collaborator

navidcy commented Aug 30, 2024

Keep doing that is fine!

@marc-white
Copy link

@navidcy I'm quite happy to keep the PRs open where there are major issues outstanding, I think it's probably the easiest way to keep track of where the updates to each recipe are up to (although we should probably mark any that aren't ready for actual review as DRAFT).

@julia-neme I think loading manually from ik11 is OK as an interim solution. I'm not sure if there's an authority/guideline on what should and should not end up in access-nri-intake (@rbeucher ? @dougiesquire ?), but as a general proposition, I'd strongly recommend that any data that external users are expected to touch should be available through one system.

@navidcy
Copy link
Collaborator

navidcy commented Aug 30, 2024

definitely we'd like to have everything in the catalog! if you can add them there do it...!

I don't know about established authorities...
feel free to be the authority! what you suggest is good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants