Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orbital sample error in renzo19 #558

Closed
elenagonzalez870 opened this issue Jun 10, 2022 · 2 comments
Closed

Orbital sample error in renzo19 #558

elenagonzalez870 opened this issue Jun 10, 2022 · 2 comments

Comments

@elenagonzalez870
Copy link
Contributor

When trying to sample orbits using the Renzo19 model, there's an error (image attached). I believe it is fixed by setting b=log10_porb_max to b=log10_porb_max[ind_massive] in the independent.py file
Screen Shot 2022-06-10 at 10 41 28 AM
@katiebreivik
Copy link
Collaborator

Thank you for opening this @elenagonzalez870 !

I'd love to help make sure that you maintain credit for finding the bug and a fix! Do you mind submitting a pull request with these changes?

@elenagonzalez870 elenagonzalez870 mentioned this issue Jun 10, 2022
Closed
@katiebreivik
Copy link
Collaborator

this is now fixed here: #563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@katiebreivik @elenagonzalez870