Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim.run.multirun : problem with kwargs_optim #24

Open
mtewes opened this issue Aug 23, 2019 · 1 comment
Open

sim.run.multirun : problem with kwargs_optim #24

mtewes opened this issue Aug 23, 2019 · 1 comment

Comments

@mtewes
Copy link
Member

mtewes commented Aug 23, 2019

Hi @martin-millon,

a user contacted me about a problem with a demo script (probably inspired by the ones given with pycs): it seems that this is related to a change in the positional arguments (namely, adding kwargs_optim) in sim.run.multirun.

Error:

Traceback (most recent call last):
File "pycs_test_j1206.py", line 70, in <module>
 pycs.sim.run.multirun("copies", lcs, myopt.spl,  optset="spl", tsrand=10.0, keepopt=True)
TypeError: multirun() takes at least 4 arguments (6 given)

Could you make this kwargs_optim optional, by setting it to None, and later "if None, make it an empty dict"? I'm asking you, as you are likely most aware of any potential related changes. Or if you prefer, modify the doc and demo files. Thanks!

@martin-millon
Copy link
Contributor

OK, I have pushed the modification. This should indeed be optional. This option is made to pass arguments to the optimization function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants