Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Part or PerformedPart objects directly as inputs for methods in partitura.musicanalysis #16

Closed
neosatrapahereje opened this issue Dec 11, 2020 · 4 comments
Assignees

Comments

@neosatrapahereje
Copy link
Member

Until now, all methods in partitura.musicanalysis take a note array (i.e., a structured array) generated from a Part object as an input. Since these methods are also commonly applied to performance information, it would be very useful to allow users to also use the methods with information from a PerformedPart object. Furthermore, allowing the input to these methods to be either a structured array, a Part or PerformedPart object would simplify their usage.

@mgrachten
Copy link
Collaborator

The ensure_notearray is now in develop and can be imported as partitura.utils.ensure_notearray. I propose to call the note_array argument to the music analysis functions something like score, score_info, or note_info (or some similar generic name) to reflect the fact that one can pass either a Part, PartGroup, or note_array.

@neosatrapahereje
Copy link
Member Author

+1 to use note_info as the argument name instead of note_array!

I just updated the methods for key and pitch estimation (in branch update_api_musicanalysis in commits
0297fc5 and 285f067 respectively), but as a result, the import score MIDI is currently broken. I will not merge this branch into develop until I fix the MIDI import.

@neosatrapahereje
Copy link
Member Author

Importing score MIDI works again!

@neosatrapahereje
Copy link
Member Author

@mgrachten Better late than never! This issue is finally solved for all methods in musicanalysis in branch update_api_musicanalysis (with commit e14dae6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants