test comparisons between bool and int variables #356
Conversation
from doc_rework, the test is literally from the new docs (was failing for ortools, includes fix) I had a look at adding it to test_constraints, but the generator to which to add these cases is not clear to me... if there is a way to simply test this with all solvers, without having to add it to test_constraints, that would also be fine for me. Even these as is just for ortools is already something.
|
Important one! I'll add it to the test_constraints generators, it should not be too much work (unless many solver fail of course ;) ) |
|
z3 was complaining quite a bit, updated the I had some issues testing Minizinc with the new comparisons, but probably due to my installation... Would be good if someone can rerun the tests for minizinc before merging |
|
test_constraints.py runs fine for me |
|
that's the only test file you needed double checked right? |
|
i do have gecode 6.3 as the default solver though.. Don't think i can easily downgrade to test |
|
Ok, yes thats the one. |
|
looks good, maybe some obsolete tests now that it's added to test_constraints but more tests doesn't hurt |
from doc_rework, the test is literally from the new docs (was failing for ortools, includes fix)
I had a look at adding it to test_constraints, but the generator to which to add these cases is not clear to me...
if there is a way to simply test this with all solvers, without having to add it to test_constraints, that would also be fine for me. Even these as is just for ortools is already something.