Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace f64 with angle type for tk2 ops #578

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat!: replace f64 with angle type for tk2 ops #578

merged 1 commit into from
Sep 4, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 3, 2024

BREAKING CHANGE: Parametric Tk2Ops take angle type rather than float.

@ss2165 ss2165 marked this pull request as ready for review September 3, 2024 17:52
@ss2165 ss2165 requested a review from a team as a code owner September 3, 2024 17:52
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from ss/hseries to main September 4, 2024 10:14
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 73.46939% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (e6acc88) to head (99943fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tket2/src/extension/angle.rs 50.00% 6 Missing ⚠️
tket2/src/serialize/pytket/encoder.rs 63.63% 3 Missing and 1 partial ⚠️
tket2/src/serialize/pytket.rs 80.00% 0 Missing and 1 partial ⚠️
tket2/src/serialize/pytket/op/native.rs 50.00% 0 Missing and 1 partial ⚠️
tket2/src/utils.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   82.90%   82.90%   -0.01%     
==========================================
  Files          45       45              
  Lines        6184     6199      +15     
  Branches     6184     6199      +15     
==========================================
+ Hits         5127     5139      +12     
- Misses        768      770       +2     
- Partials      289      290       +1     
Flag Coverage Δ
rust 82.90% <73.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit d14631f Sep 4, 2024
14 of 16 checks passed
@ss2165 ss2165 deleted the ss/nofloat branch September 4, 2024 10:56
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](tket2-py-v0.2.1...tket2-py-v0.3.0)
(2024-09-04)


### ⚠ BREAKING CHANGES

* quantum extension renamed from "quantum.tket2" to "tket2.quantum"
* Parametric Tk2Ops take angle type rather than float.
* Rename lazy extension to "hseries" and add hseries ops.
* `Tk2Op::AngleAdd` removed, use `fadd` from the hugr float ops standard
extension
* Updated to latest hugr version (`hugr-rs 0.12` / `hugr-py 0.8`). ECCs
need to be recompiled.

### Features

* HSeries ops ([#573](#573))
([e6acc88](e6acc88))
* remove Tk2Op::AngleAdd
([#567](#567))
([42cc82f](42cc82f))
* replace f64 with angle type for tk2 ops
([#578](#578))
([d14631f](d14631f))
* Update rust hugr dependency to `0.12.0`, and python hugr to `0.8.0`
([#568](#568))
([258a7c5](258a7c5))


### Bug Fixes

* quantum extension name wrong way round
([#582](#582))
([06a6838](06a6838))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
## 🤖 New release
* `tket2`: 0.1.1 -> 0.2.0
* `tket2-hseries`: 0.1.1 -> 0.2.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.2.0](tket2-v0.1.1...tket2-v0.2.0)
- 2024-09-04

### Bug Fixes
- [**breaking**] quantum extension name wrong way round
([#582](#582))

### New Features
- Extend Command::optype lifetime
([#562](#562))
- [**breaking**] Update rust hugr dependency to `0.12.0`, and python
hugr to `0.8.0` ([#568](#568))
- [**breaking**] remove Tk2Op::AngleAdd
([#567](#567))
- [**breaking**] angle type no longer parametric.
([#577](#577))
- [**breaking**] HSeries ops
([#573](#573))
- [**breaking**] replace f64 with angle type for tk2 ops
([#578](#578))
- more angle ops (construct, deconstruct, radians, equality)
([#581](#581))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.2.0](tket2-hseries-v0.1.1...tket2-hseries-v0.2.0)
- 2024-09-04

### New Features
- [**breaking**] Update rust hugr dependency to `0.12.0`, and python
hugr to `0.8.0` ([#568](#568))
- [**breaking**] HSeries ops
([#573](#573))
- [**breaking**] replace f64 with angle type for tk2 ops
([#578](#578))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants