-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update rust hugr dependency to 0.12.0
, and python hugr to 0.8.0
#568
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
- Coverage 83.09% 83.01% -0.08%
==========================================
Files 45 45
Lines 6206 6213 +7
Branches 6206 6213 +7
==========================================
+ Hits 5157 5158 +1
- Misses 768 773 +5
- Partials 281 282 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Just a couple of nits
/// | ||
/// We have to insert the extension id manually due to | ||
/// https://github.com/CQCL/hugr/issues/1496 | ||
static ref IGNORED_EXTENSION_OPS: HashSet<OpName> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gross. I think you should include Lift
also.
Co-authored-by: Douglas Wilson <141026920+doug-q@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.3.0](tket2-py-v0.2.1...tket2-py-v0.3.0) (2024-09-04) ### ⚠ BREAKING CHANGES * quantum extension renamed from "quantum.tket2" to "tket2.quantum" * Parametric Tk2Ops take angle type rather than float. * Rename lazy extension to "hseries" and add hseries ops. * `Tk2Op::AngleAdd` removed, use `fadd` from the hugr float ops standard extension * Updated to latest hugr version (`hugr-rs 0.12` / `hugr-py 0.8`). ECCs need to be recompiled. ### Features * HSeries ops ([#573](#573)) ([e6acc88](e6acc88)) * remove Tk2Op::AngleAdd ([#567](#567)) ([42cc82f](42cc82f)) * replace f64 with angle type for tk2 ops ([#578](#578)) ([d14631f](d14631f)) * Update rust hugr dependency to `0.12.0`, and python hugr to `0.8.0` ([#568](#568)) ([258a7c5](258a7c5)) ### Bug Fixes * quantum extension name wrong way round ([#582](#582)) ([06a6838](06a6838)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
## 🤖 New release * `tket2`: 0.1.1 -> 0.2.0 * `tket2-hseries`: 0.1.1 -> 0.2.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.2.0](tket2-v0.1.1...tket2-v0.2.0) - 2024-09-04 ### Bug Fixes - [**breaking**] quantum extension name wrong way round ([#582](#582)) ### New Features - Extend Command::optype lifetime ([#562](#562)) - [**breaking**] Update rust hugr dependency to `0.12.0`, and python hugr to `0.8.0` ([#568](#568)) - [**breaking**] remove Tk2Op::AngleAdd ([#567](#567)) - [**breaking**] angle type no longer parametric. ([#577](#577)) - [**breaking**] HSeries ops ([#573](#573)) - [**breaking**] replace f64 with angle type for tk2 ops ([#578](#578)) - more angle ops (construct, deconstruct, radians, equality) ([#581](#581)) </blockquote> ## `tket2-hseries` <blockquote> ## [0.2.0](tket2-hseries-v0.1.1...tket2-hseries-v0.2.0) - 2024-09-04 ### New Features - [**breaking**] Update rust hugr dependency to `0.12.0`, and python hugr to `0.8.0` ([#568](#568)) - [**breaking**] HSeries ops ([#573](#573)) - [**breaking**] replace f64 with angle type for tk2 ops ([#578](#578)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
The main change is the drop of
CustomOp
s, requiring opaque ops to always be resolved.This is a bit of a problem with the current code, as we used
OpaqueOp
s not backed by a definition to declare operations from python.For the moment, we leave
PyExtensionOp
unimplemented and disable the pauli prop tests that depended on it.tket2/tket2-py/src/ops.rs
Lines 247 to 251 in 473c9f5
tket2/tket2-py/test/test_pauli_prop.py
Lines 96 to 100 in 473c9f5
I'll raise an issue to get them fixed them.
BREAKING CHANGE: Updated to latest hugr version (
hugr-rs 0.12
/hugr-py 0.8
). ECCs need to be recompiled.