Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs and PPP #206

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix docs and PPP #206

merged 1 commit into from
Nov 12, 2018

Conversation

juxd
Copy link

@juxd juxd commented Nov 12, 2018

I updated my PPP :)

@juxd juxd self-assigned this Nov 12, 2018
rrtheonlyone
rrtheonlyone approved these changes Nov 12, 2018
View reviewed changes
Copy link

@rrtheonlyone rrtheonlyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 426

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.678%
Totals Coverage Status
Change from base Build 425: 0.0%
Covered Lines: 2889
Relevant Lines: 3295
💛 - Coveralls

monmanuela
monmanuela approved these changes Nov 12, 2018
View reviewed changes
Copy link

@monmanuela monmanuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whee LGTM 🌈

@rrtheonlyone rrtheonlyone merged commit fb4d98e into CS2103-AY1819S1-T16-3:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrtheonlyone rrtheonlyone rrtheonlyone approved these changes

@monmanuela monmanuela monmanuela approved these changes

Assignees

@juxd juxd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juxd @coveralls @rrtheonlyone @monmanuela