Add tests for Chart and ChartList to improve coverage, add body for ChartException #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request
Merge pull request
nivenang
changed the title
chung-ming
approved these changes
Apr 3, 2019
chung-ming
reviewed
Apr 4, 2019
| assertFalse(firstCountryChartValueFour.equals(1)); | ||
|
|
||
| // null -> returns false | ||
| assertFalse(firstCountryChartValueFour.equals(null)); |
There was a problem hiding this comment.
From PMD 1.9 onwards, tests for null should not use the equals() method. The '==' operator should be used instead. Suggest to change it to:
assertFalse(firstCountryChartValueFour == null);
|
Good job in coming out with the test cases and increasing the coverage percentage. The chart seems to be thoroughly tested now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.