Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: organizations #1996

Merged
merged 3 commits into from Feb 7, 2020
Merged

doc: organizations #1996

merged 3 commits into from Feb 7, 2020

Conversation

@opqdonut
Copy link
Collaborator

opqdonut commented Feb 6, 2020

for #1893

Definition of Done / Review checklist

Reviewability

  • link to issue
  • note if PR is on top of other PR
  • note if related change in rems-deploy repo
  • consider adding screenshots for ease of review

API

  • API is documented and shows up in Swagger UI
  • API is backwards compatible or completely new
  • Events are backwards compatible

Documentation

  • update changelog if necessary
  • add or update docstrings for namespaces and functions
  • components are added to guide page
  • documentation at least for config options (i.e. docs folder)
  • ADR for major architectural decisions or experiments

Different installations

  • new configuration options added to rems-deploy repository
  • instance specific translations (i.e. LBR kielivara)

Testing

  • complex logic is unit tested
  • valuable features are integration / browser / acceptance tested automatically

Accessibility

  • all icons have the aria-label attribute
  • all fields have a label
  • errors are linked to fields with aria-describedby
  • contrast is checked
  • conscious decision about where to move focus after an action

Follow-up

  • new tasks are created for pending or remaining tasks
  • no critical TODOs left to implement
opqdonut added 3 commits Feb 6, 2020
update restrictions to match #1997
@Macroz
Macroz approved these changes Feb 7, 2020
@opqdonut opqdonut merged commit f1fcc9c into master Feb 7, 2020
7 checks passed
7 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@opqdonut opqdonut deleted the doc-organizations branch Feb 7, 2020
@opqdonut opqdonut mentioned this pull request Feb 7, 2020
13 of 25 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.