Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: organizations #1996

Merged
merged 3 commits into from
Feb 7, 2020
Merged

doc: organizations #1996

merged 3 commits into from
Feb 7, 2020

Conversation

opqdonut
Copy link
Contributor

@opqdonut opqdonut commented Feb 6, 2020

for #1893

Definition of Done / Review checklist

Reviewability

  • link to issue
  • note if PR is on top of other PR
  • note if related change in rems-deploy repo
  • consider adding screenshots for ease of review

API

  • API is documented and shows up in Swagger UI
  • API is backwards compatible or completely new
  • Events are backwards compatible

Documentation

  • update changelog if necessary
  • add or update docstrings for namespaces and functions
  • components are added to guide page
  • documentation at least for config options (i.e. docs folder)
  • ADR for major architectural decisions or experiments

Different installations

  • new configuration options added to rems-deploy repository
  • instance specific translations (i.e. LBR kielivara)

Testing

  • complex logic is unit tested
  • valuable features are integration / browser / acceptance tested automatically

Accessibility

  • all icons have the aria-label attribute
  • all fields have a label
  • errors are linked to fields with aria-describedby
  • contrast is checked
  • conscious decision about where to move focus after an action

Follow-up

  • new tasks are created for pending or remaining tasks
  • no critical TODOs left to implement

@opqdonut opqdonut merged commit f1fcc9c into master Feb 7, 2020
@opqdonut opqdonut deleted the doc-organizations branch February 7, 2020 11:53
@opqdonut opqdonut mentioned this pull request Feb 7, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Macroz Macroz Macroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opqdonut @Macroz