Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to make browser tests more robust wrt. cleaning up database #2458

Merged
merged 2 commits into from
Nov 27, 2020
Merged

try to make browser tests more robust wrt. cleaning up database #2458

merged 2 commits into from
Nov 27, 2020

Conversation

opqdonut
Copy link
Contributor

  • clean up database even if a fixture fails
  • assert that database is empty when starting up

Definition of Done / Review checklist

Follow-up

  • no critical TODOs left to implement

@opqdonut
fix: use try-finally in reset-db-fixture
e661486 
... to try to guarantee a clean database is left behind after e.g.
failures in other fixtures
@opqdonut
test: call assert-no-existing-data! in browser test fixtures
d305f9a
@Macroz Macroz merged commit 10aa8e4 into master Nov 27, 2020
@Macroz Macroz deleted the reset-db-harder branch November 27, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Macroz Macroz Macroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opqdonut @Macroz