Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an advice to docs to use .toParams() over .toString() #90

Closed
Suor opened this issue Oct 27, 2016 · 5 comments
Closed

Add an advice to docs to use .toParams() over .toString() #90

Suor opened this issue Oct 27, 2016 · 5 comments

Comments

@Suor
Copy link
Contributor

Suor commented Oct 27, 2016

Or even suggest that .toString() is for debugging purposes only as values are not escaped by actual backend.

@prust
Copy link
Collaborator

prust commented Oct 27, 2016

@Suor: Due to security concerns? Maybe along with a mention of SQL injection attacks and a link to https://en.wikipedia.org/wiki/SQL_injection#Parameterized_statements ?

@Suor
Copy link
Contributor Author

Suor commented Oct 27, 2016

Yes, and not only security. People came to me with issues several times
when database was not understanding query stringification.

In one case it was even custom type that just db library understands by
it's own hooks.

27 окт. 2016 г. 22:23 пользователь "Peter Rust" notifications@github.com
написал:

@Suor https://github.com/Suor: Due to security concerns? Maybe along
with a mention of SQL injection attacks and a link to
https://en.wikipedia.org/wiki/SQL_injection#Parameterized_statements ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#90 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARVx6HLTWjp68OZ_X1YHYVG-2jqvXJRks5q4MIGgaJpZM4Kh7r2
.

@prust
Copy link
Collaborator

prust commented Oct 27, 2016

@Suor: I see, good to know. I can add something to the "Use" sections on the readme & the docs, as well as a mention in the .toString() & .toParams() documentation.

@Suor
Copy link
Contributor Author

Suor commented Oct 27, 2016 via email

@prust prust closed this as completed in b38c07b Oct 29, 2016
@prust
Copy link
Collaborator

prust commented Oct 29, 2016

Thanks for encouraging me to do this @Suor, addressed in b38c07b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants