Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): output .noWait() as 'NOWAIT' #108

Merged
merged 2 commits into from
Nov 6, 2018
Merged

fix(v2): output .noWait() as 'NOWAIT' #108

merged 2 commits into from
Nov 6, 2018

Conversation

joelmukuthu
Copy link
Contributor

@joelmukuthu joelmukuthu commented Oct 28, 2018

Was previously output as 'NO WAIT'.

This applies the fix made in #106 to the v2 branch.

was previously output as 'NO WAIT'
@joelmukuthu
Copy link
Contributor Author

@prust any idea why the build is failing or how I can fix it?

@prust
Copy link
Collaborator

prust commented Oct 29, 2018

@joelmukuthu: Yes, the same thing happened on master recently and I fixed it in 67650011e30812b79243. It's because mocha doesn't support Node 4.x or earlier (and/or doesn't pin to dependencies that do).

I suppose that's technically fair, since Node 4.x ended its maintenance cycle in April, but it makes me feel like a grumpy old man (why are major platform versions only supported for a few years instead of a few decades?)

We'll need to update the .travis.yml file to match what's on master (Node 6.x & 8.x), even though SQLBricks still works fine on Node 4.x and 0.10.x and 0.12.x.

@joelmukuthu
Copy link
Contributor Author

Sorry for the late response. Haha, yeah the JS/Node community tends to move a bit too fast, which would not be a problem if only we'd support the old stuff a bit longer. Speaking of, how's it going with V3? :)

@prust prust merged commit d381b58 into rockdai:2.x Nov 6, 2018
@prust
Copy link
Collaborator

prust commented Nov 6, 2018

thanks @joelmukuthu, this is merged & deployed to npm as 2.0.4.

how's it going with V3

Well, I guess I don't move too fast :-) I'm going to need to carve out some time to move forward on v3. I do want to, and plan to, but it's a matter of making the time in my work day or in my afternoons/evenings, both of which are a bit tight at the moment.

@joelmukuthu
Copy link
Contributor Author

Great, thanks! Sounds good with the plan and I'm not blocked on anything so no rush. I'm looking forward to it all the same! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants