remove underscore from sql-bricks codebase #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is much sloppier than the underscore function, but the deepest object the tests compare to is something like [["Paul", "Maud'Dib"]]
|
@pgarrison: Thank you! This looks good to me (after a cursory skim) and it looks like the tests pass, so that's a good sign. I'm going to go ahead & merge, but we may want to publish this as a pre-release version or ask a few people who are using the library to test it out in their projects to give it more exercise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing underscore is now of high importance since the outdated underscore version in use now has a critical vulnerability
I addressed some issues from the prior PR #112, building on @schuttsm's code