Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -moz-transform and -o-transform due to minimal usage #589

Merged
merged 1 commit into from
Sep 30, 2016
Merged

remove -moz-transform and -o-transform due to minimal usage #589

merged 1 commit into from
Sep 30, 2016

Conversation

lukasoppermann
Copy link
Contributor

-moz-transform has been removed in FF16 (currently FF stable is 37) and -o-transform at 11.5 (current stable Opera is 27).

If you use something like autoprefixer for the last 2,3 or even 5 versions, you still get an error.
I would say that suggesting to use vendor-prefixes for very old browser is an anti-pattern or at least not a best-practise and should not be encouraged by something like csslint.

Also, including a rule like this basically forces you to either turn off the rule (not good) or include all browser prefixes in autoprefixer (also bad).

Note: This is true for some other prefixed elements as well. If you merge this one, I am happy to check which other elements can be removed and add another PR.

@HerrBertling
Copy link

👍

@bwinton
Copy link

bwinton commented Jun 2, 2015

So, I like the idea behind this, but the file you changed is just to recognize vendor-prefixes and suggest that we use the standard fallback, so I think you want to leave that one alone, and instead change line 77 of src/rules/compatible-vendor-prefixes.js (and add a test to the bottom of tests/rules/compatible-vendor-prefixes.js)… Does that sound reasonable?

@lukasoppermann
Copy link
Contributor Author

@bwinton thanks, I changed it the way you suggested.

@lukasoppermann
Copy link
Contributor Author

@nschonni any change of getting this merged?

@himedlooff
Copy link

👍

@frvge frvge added the Triage label Jan 10, 2016
@lukasoppermann
Copy link
Contributor Author

Hey @frvge will this ever be merged?

@frvge frvge removed the Triage label Sep 30, 2016
@frvge
Copy link
Contributor

frvge commented Sep 30, 2016

Even though behavior changes, I think it's OK to move forward. FF16 is from 2012 and Opera 11.5 from 2011. Getting an error to slightly update your CSS after 4 years is IMO acceptable. FYI @XhmikosR .

@frvge frvge merged commit 8cfd74a into CSSLint:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants