Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #666 : Make core (dist/csslint.js) compatible with CodeMirror in … #672

Merged

Conversation

orionlee
Copy link
Contributor

@XhmikosR Please see Fix #666 : Make core (dist/csslint.js) compatible with CodeMirror in browser,

  • in general, any environment that supports CommonJS module,
    which expect proper module, exports global

…ror in browser,

- in general, any environment that supports CommonJS module,
  and expect proper module, exports global
@XhmikosR
Copy link
Member

I'll have a look as soon as I'm at home.

My only concern is if this will break any of the rest of the environments.

On Aug 25, 2016 10:02, "orionlee" notifications@github.com wrote:

@XhmikosR https://github.com/XhmikosR Please see Fix #666
#666 : Make core
(dist/csslint.js) compatible with CodeMirror in browser,

  • in general, any environment that supports CommonJS module, which
    expect proper module, exports global

You can view, comment on, or merge this pull request online at:

#672
Commit Summary

File Changes

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#672, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtWwG2juPSHJ5-YUl4PkCgfgtSjwGks5qjT4MgaJpZM4JswRd
.

@orionlee
Copy link
Contributor Author

@XhmikosR any update? Thanks.

@XhmikosR
Copy link
Member

Sorry, I forgot about it. I'll try to take of this tomorrow.

On Sep 13, 2016 19:18, "orionlee" notifications@github.com wrote:

@XhmikosR https://github.com/XhmikosR any update? Thanks.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#672 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVVtckPoPq2gpUD0pQLcwyZYzD3rfmtks5qpszfgaJpZM4JswRd
.

@XhmikosR XhmikosR merged commit b17baf5 into CSSLint:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants