Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide banner temporarily #180

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Hide banner temporarily #180

merged 1 commit into from
Oct 4, 2021

Conversation

AlexJBanks
Copy link
Member

retain code for future use

retain code for future use
Copy link
Member

@Danyc0 Danyc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the idea of leaving code in "in case we need it later" is pretty bad practice when using version control. It just leaves clutter and damages readability for future maintainers. When using version control it's unnecessary because the changes can just be pulled out of the history if required.

I guess I'm happy to be overruled on this if necessary

@JTWWilson
Copy link
Contributor

Very good point and one I hadn't thought about. Perhaps we raise an issue reminding us to add this in again ~August 2022?

@AlexJBanks
Copy link
Member Author

@Danyc0 This isn't meant to be a "in case we need it later", it's meant to be a "we will use this later". I need to clean up the actual way that it's hidden - i.e. check if text exists and only if it does display the banner, but I don't have time to do that now and have added it to #153

@AlexJBanks
Copy link
Member Author

in the meantime the website says "if you're joining us in september" and it's october so it cannot remain up, temporary fix or not.

@AlexJBanks AlexJBanks mentioned this pull request Oct 4, 2021
6 tasks
@AlexJBanks AlexJBanks linked an issue Oct 4, 2021 that may be closed by this pull request
@Danyc0
Copy link
Member

Danyc0 commented Oct 4, 2021

I really don't like the idea that the code is there, and is actually transmitted and can be seen in the source, but just isn't displayed. That's so messy and wasteful.
I completely agree though that the banner needs to go, so I'll approve and merge this now, with a note in #153 that it needs cleaning up

@Danyc0 Danyc0 merged commit f12913b into master Oct 4, 2021
@JTWWilson JTWWilson deleted the hide-banner branch November 9, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Temporary Banner
3 participants