Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple bugfix merges #1531

Merged
merged 3 commits into from Jul 6, 2020
Merged

Simple bugfix merges #1531

merged 3 commits into from Jul 6, 2020

Conversation

ColdHeat
Copy link
Member

@ColdHeat ColdHeat commented Jul 6, 2020

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #1531 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
+ Coverage   89.25%   89.32%   +0.06%     
==========================================
  Files         129      129              
  Lines        6554     6555       +1     
==========================================
+ Hits         5850     5855       +5     
+ Misses        704      700       -4     
Impacted Files Coverage Δ
CTFd/api/v1/challenges.py 95.30% <100.00%> (+0.35%) ⬆️
CTFd/utils/config/visibility.py 94.44% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc70fb...b40d0ca. Read the comment docs.

@ColdHeat ColdHeat merged commit 7dcfba4 into master Jul 6, 2020
@ColdHeat ColdHeat deleted the 1530-bug-fixes branch July 6, 2020 19:35
UnknownSilicon pushed a commit to UnknownSilicon/CTFd that referenced this pull request Oct 4, 2023
* Closes CTFd#1530 
* Clean up some wording and comments
* Pin isort version to fix flake8 issue (gforcada/flake8-isort#88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solves undefined if visibility is set to hidden
1 participant